Copying to a new storage - wrong message about snapshots

towerbr · 11 November 2018 19:04

I’m migrating a backup to a new storage (same repository). To take advantage of the already generated chunks, I ran a copy of the last revision from the old storage to the new (empty) storage and got:

INFO SNAPSHOT_COPY Nothing to copy, all snapshot revisions exist at the destination.

It took me a few minutes to find out that I made a typo in the name of the snapshot…

In this case I think there should be an error message that the snapshot was not found instead of “all snapshot revisions exist”…

Probably some additional condition here:

github.com

gilbertchen/duplicacy/blob/bfb4b44c0ab9afbbd33cd641c2dab49c3518b751/src/duplicacy_backupmanager.go#L1609


				revisionMap[id][revision] = false
				continue
			}


			snapshot := manager.SnapshotManager.DownloadSnapshot(id, revision)
			snapshots = append(snapshots, snapshot)
		}


	}


	if len(snapshots) == 0 {
		LOG_INFO("SNAPSHOT_COPY", "Nothing to copy, all snapshot revisions exist at the destination.")
		return true
	}


	chunks := make(map[string]bool)
	otherChunks := make(map[string]bool)


	for _, snapshot := range snapshots {


		if revisionMap[snapshot.ID][snapshot.Revision] == false {

Or maybe because the “for” preceding the “if” above first tests for the revisions and then for the snapshots.

github.com

gilbertchen/duplicacy/blob/bfb4b44c0ab9afbbd33cd641c2dab49c3518b751/src/duplicacy_backupmanager.go#L1576


		_, found := revisionMap[id]
		if !found {
			revisionMap[id] = make(map[int]bool)
		}
		revisions, err := manager.SnapshotManager.ListSnapshotRevisions(id)
		if err != nil {
			LOG_ERROR("SNAPSHOT_LIST", "Failed to list all revisions for snapshot %s: %v", id, err)
			return false
		}


		for _, revision := range revisions {
			if len(revisionsToBeCopied) > 0 {
				if _, found := revisionMap[id][revision]; found {
					revisionMap[id][revision] = true
				} else {
					revisionMap[id][revision] = false
					continue
				}
			} else {
				revisionMap[id][revision] = true
			}

But I’m not sure about the best change to solve the problem.